Change test to not trigger emoji error #10117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
It looks like you need to include something that won't tokenize to get rustdoc to display a warning. Really anything you can think of to make it display a warning should be fine. Also, while you're there, can you remove the |
This change is needed to land rust-lang/rust#88781, as it changes the handling of emojis in source code to treat them as identifiers.
estebank
force-pushed
the
update-test-for-emoji
branch
from
32e4ada to
0dfe70f
Compare
|
The only non-tokenizable char I could think of was |
|
Backtick seems fine. Any of the rustdoc lints would also work. @bors r+ Feel free to bump cargo in your PR, or let me know if you want me to do it separately. |
|
📌 Commit 0dfe70f has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is needed to land rust-lang/rust#88781, as it changes the
handling of emojis in source code to treat them as identifiers.